Skip to content

refactor(card): locale selection to use fallback logic#942

Merged
FajarKim merged 1 commit intomasterfrom
FajarKim-patch-1
Apr 2, 2026
Merged

refactor(card): locale selection to use fallback logic#942
FajarKim merged 1 commit intomasterfrom
FajarKim-patch-1

Conversation

@FajarKim
Copy link
Copy Markdown
Owner

@FajarKim FajarKim commented Apr 2, 2026

Description

Refactor locale selection in file src/card.ts to use fallback logic.

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Misc change (updated other files non-breaking change)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with npm test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

None

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
github-readme-profile Ready Ready Preview, Comment Apr 2, 2026 10:25am

@github-actions github-actions Bot added the card label Apr 2, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.00%. Comparing base (eea8aa1) to head (9743365).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #942      +/-   ##
==========================================
+ Coverage   66.55%   67.00%   +0.44%     
==========================================
  Files          13       13              
  Lines         296      300       +4     
  Branches       71       73       +2     
==========================================
+ Hits          197      201       +4     
  Misses         86       86              
  Partials       13       13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FajarKim FajarKim merged commit 093ba30 into master Apr 2, 2026
12 checks passed
@FajarKim FajarKim deleted the FajarKim-patch-1 branch April 2, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

card

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@FajarKim